FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 34 |
25 |
0 |
0 |
org.miloss.fgsms.agentcore.ConfigLoader
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.miloss.fgsms.agentcore.ConfigLoader.loadProperties() |
STYLE |
REC_CATCH_EXCEPTION |
174 |
Medium |
| Unread public/protected field: org.miloss.fgsms.agentcore.ConfigLoader.dasport |
STYLE |
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD |
93 |
Medium |
org.miloss.fgsms.agentcore.DataPusher
| Bug |
Category |
Details |
Line |
Priority |
| org.miloss.fgsms.agentcore.DataPusher.PrepMessage(MessageCorrelator, PolicyHelper) might ignore java.lang.Exception |
BAD_PRACTICE |
DE_MIGHT_IGNORE |
574 |
Medium |
| Redundant nullcheck of current, which is known to be non-null in org.miloss.fgsms.agentcore.DataPusher.run() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
696 |
Medium |
| Exception is caught when Exception is not thrown in org.miloss.fgsms.agentcore.DataPusher.CheckPersistStore() |
STYLE |
REC_CATCH_EXCEPTION |
902 |
Medium |
| Exception is caught when Exception is not thrown in org.miloss.fgsms.agentcore.DataPusher.ReadAllText(InputStream) |
STYLE |
REC_CATCH_EXCEPTION |
975 |
Medium |
| Return value of org.miloss.fgsms.services.interfaces.policyconfiguration.ServicePolicyResponseMsg.getPolicy() ignored, but method has no side effect |
STYLE |
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT |
317 |
Medium |
| Write to static field org.miloss.fgsms.agentcore.DataPusher.outboundQueue from instance method new org.miloss.fgsms.agentcore.DataPusher() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
86 |
Medium |
| Write to static field org.miloss.fgsms.agentcore.DataPusher.policyCache from instance method new org.miloss.fgsms.agentcore.DataPusher() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
85 |
Medium |
| org.miloss.fgsms.agentcore.DataPusher.PrepMessage(MessageCorrelator, PolicyHelper) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
593 |
Medium |
| org.miloss.fgsms.agentcore.DataPusher.PrepMessage(MessageCorrelator, PolicyHelper) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
571 |
Medium |
org.miloss.fgsms.agentcore.DependencyHelper
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of header, which is known to be non-null in org.miloss.fgsms.agentcore.DependencyHelper.insertRelatedMessageHeader(String, SOAPMessageContext) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
141 |
Medium |
| Redundant nullcheck of header, which is known to be non-null in org.miloss.fgsms.agentcore.DependencyHelper.insertThreadIdHeader(String, SOAPMessageContext) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
191 |
Medium |
org.miloss.fgsms.agentcore.OneWayJudge
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.miloss.fgsms.agentcore.OneWayJudge.determineOneWay(String, SOAPMessageContext, String) |
STYLE |
REC_CATCH_EXCEPTION |
100 |
Medium |
| org.miloss.fgsms.agentcore.OneWayJudge.determineOneWay(String, SOAPMessageContext, String) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
87 |
Medium |
org.miloss.fgsms.agentcore.PersistentStorage
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to dp in org.miloss.fgsms.agentcore.PersistentStorage.doWork(boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
220 |
High |
| Exception is caught when Exception is not thrown in org.miloss.fgsms.agentcore.PersistentStorage.init(String[]) |
STYLE |
REC_CATCH_EXCEPTION |
100 |
Medium |
| Write to static field org.miloss.fgsms.agentcore.PersistentStorage.noloop from instance method org.miloss.fgsms.agentcore.PersistentStorage.init(String[]) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
114 |
Medium |
org.miloss.fgsms.agentcore.PolicyFetch
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.miloss.fgsms.agentcore.PolicyFetch.readAllText(InputStream) |
STYLE |
REC_CATCH_EXCEPTION |
345 |
Medium |
org.miloss.fgsms.agentcore.StatisticalHelper
| Bug |
Category |
Details |
Line |
Priority |
| org.miloss.fgsms.agentcore.StatisticalHelper.cfg should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
42 |
Medium |
org.miloss.fgsms.agentcore.mp.DefaultMessageProcessor
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to start in org.miloss.fgsms.agentcore.mp.DefaultMessageProcessor.processMessageInput(String, int, String, String, String, String, HashMap, String, String, String, String) |
STYLE |
DLS_DEAD_LOCAL_STORE |
309 |
Medium |
| Inconsistent synchronization of org.miloss.fgsms.agentcore.mp.DefaultMessageProcessor.pool; locked 64% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
691 |
Medium |
| Redundant nullcheck of j, which is known to be non-null in org.miloss.fgsms.agentcore.mp.DefaultMessageProcessor.getPolicyIfAvailable(String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
178 |
Medium |
| Unread field: org.miloss.fgsms.agentcore.mp.DefaultMessageProcessor.myHostname |
PERFORMANCE |
URF_UNREAD_FIELD |
81 |
Medium |
| org.miloss.fgsms.agentcore.mp.DefaultMessageProcessor.removeDeadMessage() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
532 |
Medium |
