The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Class | Bugs |
|---|---|
| org.miloss.fgsms.agents.HttpServletAgent | 5 |
| org.miloss.fgsms.agents.InputStreamRequestWrapper | 1 |
| org.miloss.fgsms.agents.SnifferResponseWrapper | 2 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in org.miloss.fgsms.agents.HttpServletAgent.doFilter(ServletRequest, ServletResponse, FilterChain), since all org.miloss.fgsms.agents.SnifferResponseWrapper are instances of org.miloss.fgsms.agents.SnifferResponseWrapper | STYLE | BC_VACUOUS_INSTANCEOF | 78 | Medium |
| The method name org.miloss.fgsms.agents.HttpServletAgent.ProcessInboundMessage(InputStreamRequestWrapper) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 92-201 | Medium |
| The method name org.miloss.fgsms.agents.HttpServletAgent.ProcessOutboundMessage(InputStreamRequestWrapper, SnifferResponseWrapper, String) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 204-243 | Medium |
| Nullcheck of req1 at line 129 of value previously dereferenced in org.miloss.fgsms.agents.HttpServletAgent.ProcessInboundMessage(InputStreamRequestWrapper) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 94 | Medium |
| Return value of javax.servlet.ServletRequestWrapper.getRemoteAddr() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 141 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in new org.miloss.fgsms.agents.InputStreamRequestWrapper(HttpServletRequest) | STYLE | REC_CATCH_EXCEPTION | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.miloss.fgsms.agents.SnifferResponseWrapper.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 101 | Medium |
| Unread public/protected field: org.miloss.fgsms.agents.SnifferResponseWrapper.wrapped | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 39 | Medium |