The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of res, which is known to be non-null in org.miloss.fgsms.presentation.AvailabilityChart.produceDataset(Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.miloss.fgsms.presentation.GetPluginInformationExt.RefreshedAt doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.miloss.fgsms.presentation.Helper.PrettyPrintXMLToHtml(String) | STYLE | REC_CATCH_EXCEPTION | 295 | Medium |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.Helper.ShowOpStat(SecurityWrapper, OpStatusService, String) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 1153 | High |
| org.miloss.fgsms.presentation.Helper.BuildSLAAction(List, PCS, SecurityWrapper) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 660 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.MachineNetworkData.Contains(String) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 39-44 | Medium |
| The method name org.miloss.fgsms.presentation.MachineNetworkData.Size() doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.ManageHelper.GetNICNamesAsHtmlListbox(String, String, String, PCS, SecurityWrapper, List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 73-102 | Medium |
| The method name org.miloss.fgsms.presentation.ManageHelper.GetPartitionNamesAsHtmlListboxForFreeSpace(String, String, String, PCS, SecurityWrapper, List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 106-134 | Medium |
| The method name org.miloss.fgsms.presentation.ManageHelper.GetPartitionNamesAsHtmlListboxForThroughput(String, String, String, PCS, SecurityWrapper, List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 41-69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 48-126 | Medium |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 57 | High |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 65 | High |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 73 | High |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 80 | High |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 87 | High |
| "." or "|" used for regular expression in org.miloss.fgsms.presentation.OpStatHelper.GetStatusAll(IProxyLoader, ServletContext, HttpServletRequest, HttpServletResponse) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 95 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.OsAgentStatusHelper.ContainsOSAgentCallbackURL(List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 64-72 | Medium |
| The method name org.miloss.fgsms.presentation.OsAgentStatusHelper.GetOSAgentCallBackURL(List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 82-90 | Medium |
| The method name org.miloss.fgsms.presentation.OsAgentStatusHelper.GetStatus(OpStatusService, String, SecurityWrapper) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 44-54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.miloss.fgsms.presentation.SortableStatusList defines compareTo(SortableStatusList) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 58-63 | Medium |
| The method name org.miloss.fgsms.presentation.SortableStatusList.ConvertToFriendlyName(SortableStatusList$Status) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 98-116 | Medium |
| The method name org.miloss.fgsms.presentation.SortableStatusList.ConvertToImageLink(SortableStatusList$Status) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 76-93 | Medium |
| Unread public/protected field: org.miloss.fgsms.presentation.SortableStatusList.url | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.miloss.fgsms.presentation.SortableStatusList$Status.value field is public and mutable | BAD_PRACTICE | ME_MUTABLE_ENUM_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Repeated conditional test in org.miloss.fgsms.presentation.TransactionLogActionBreakDown.produceDataset(Map) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 47 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.TransactionLogActionSet.Contains(String) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 40-45 | Medium |
| The method name org.miloss.fgsms.presentation.TransactionLogActionSet.Size() doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.TransactionLogData.Contains(String) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 38-43 | Medium |
| The method name org.miloss.fgsms.presentation.TransactionLogData.Size() doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.miloss.fgsms.presentation.TransactionLogTimeStampStruct.ResponseTime doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.miloss.fgsms.presentation.TransactionLogViewerData.GetRenderedData(GetMessageLogsResponseMsg) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 164-238 | Medium |
| The method name org.miloss.fgsms.presentation.TransactionLogViewerData.ParseIdentities(List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 320-330 | Medium |
| Repeated conditional test in org.miloss.fgsms.presentation.TransactionLogViewerData.GetRenderedData(GetMessageLogsResponseMsg) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 171 | High |
| Repeated conditional test in org.miloss.fgsms.presentation.TransactionLogViewerData.produceDataset(Map) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 249 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.miloss.fgsms.presentation.UDDIConfig.IsjUDDI doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
| Unread public/protected field: org.miloss.fgsms.presentation.UDDIConfig.IsjUDDI | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 49 | Medium |